Skip to content

Fixed crash in Android #8104

Merged
d4vidi merged 3 commits intomasterfrom
bugfix/8065-react-native-0801-navigationturbomodulekt-284-line
Sep 15, 2025
Merged

Fixed crash in Android #8104
d4vidi merged 3 commits intomasterfrom
bugfix/8065-react-native-0801-navigationturbomodulekt-284-line

Conversation

@gosha212
Copy link
Copy Markdown
Contributor

@gosha212 gosha212 commented Aug 31, 2025 •
edited
Loading

Crash in NavigationTurboModule.kt.
Fixed null safety

@gosha212
Fixed #8065
bb98d36 
Crash in NavigationTurboModule.kt
@gosha212 gosha212 linked an issue Aug 31, 2025 that may be closed by this pull request
React-Native 0.80.1 NavigationTurboModule.kt 284 Line #8065
Closed
d4vidi
d4vidi reviewed Sep 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@d4vidi d4vidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's hard to repro, but still - is there a way we can test this e2e? Perhaps using a special activity with "tricks" inside it's onResume() etc.

Comment thread lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationTurboModule.kt
Comment thread lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationTurboModule.kt
Comment thread lib/android/app/src/main/java/com/reactnativenavigation/react/NavigationTurboModule.kt Outdated
@gosha212 @d4vidi
Update lib/android/app/src/main/java/com/reactnativenavigation/react/…
8cf077b 
…NavigationTurboModule.kt

Co-authored-by: d4vidi <amit.d4vidi@gmail.com>
@gosha212
Copy link
Copy Markdown
Contributor Author

gosha212 commented Sep 1, 2025

I know it's hard to repro, but still - is there a way we can test this e2e? Perhaps using a special activity with "tricks" inside it's onResume() etc.

I've a reproduction for this bug. Just start the app before the metro in debug mode.

@d4vidi
Copy link
Copy Markdown
Collaborator

d4vidi commented Sep 9, 2025

I know it's hard to repro, but still - is there a way we can test this e2e? Perhaps using a special activity with "tricks" inside it's onResume() etc.

I've a reproduction for this bug. Just start the app before the metro in debug mode.

So can we run detox in debug mode to test this?

@d4vidi d4vidi merged commit b0cb3fb into master Sep 15, 2025
4 checks passed
@d4vidi d4vidi deleted the bugfix/8065-react-native-0801-navigationturbomodulekt-284-line branch September 15, 2025 14:06
@angelos3lex
Copy link
Copy Markdown

angelos3lex commented Jan 22, 2026 •
edited
Loading

I know it's hard to repro, but still - is there a way we can test this e2e? Perhaps using a special activity with "tricks" inside it's onResume() etc.

I've a reproduction for this bug. Just start the app before the metro in debug mode.

I verify. On android, if we open first the app then the metro and reload, then we get activity is null error.
If we first open metro, then the app, it's ok. (RN 0.83 and 8.7.4 navigation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d4vidi d4vidi d4vidi approved these changes

Assignees

No one assigned

Labels

platform: Android type: accepted/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

React-Native 0.80.1 NavigationTurboModule.kt 284 Line

3 participants

@gosha212 @d4vidi @angelos3lex